Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 7.4 #762

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Allow PHP 7.4 #762

merged 2 commits into from
Sep 3, 2020

Conversation

mikemand
Copy link
Contributor

@mikemand mikemand commented Sep 1, 2020

Fixes #756.

@mikemand
Allow PHP 7.4
48c557d 
Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
@nWidart
Copy link
Member

nWidart commented Sep 2, 2020

Thanks! Should this also add they 7.4 version in the travis version matrix maybe?
For some reason, travis has been failing due to memory issues :/

@mikemand
Copy link
Contributor Author

mikemand commented Sep 2, 2020

I can try that if you want, yeah. The memory issues are something Composer is doing. Probably something to do with how old the dependencies are...

@mikemand
Add PHP 7.4 to Travis config
64e092b 
Signed-off-by: Micheal Mand <micheal@kmdwebdesigns.com>
@nWidart
Copy link
Member

nWidart commented Sep 3, 2020

Thanks!

I see the builds started failing 4 months ago (30th April 2020).
I would be surprised if the fact of old dependencies could cause this 😱

@nWidart nWidart merged commit f12eef6 into AsgardCms:master Sep 3, 2020
@mikemand mikemand deleted the hotfix/allow-php7.4 branch September 3, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikemand @nWidart